Support concurrency for IAVL and fix Racing conditions #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should target master instead of the release branch, this issue is probably present on v0.20 as well and v1.0.0. |
|
@julienrbrt We can also backport this to older release versions as well though right? |
|
@julienrbrt Awesome, let's do this: I'll close this issue for now and create a PR pointing at main. After we have that reviewed we can probably backport this to all necessary branches |
|
Awesome, let's do that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cref: #696
This PR fixes the problem stated above by replacing maps that causes racing conditions to sync map to be thread safe.
Confirmed and tested on a node with the following procedure:
After 40+ minutes, node does seem to crash, but suspecting this may be to different concurrency issues (still doing more investigation)